[Openmp-commits] [PATCH] D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Oct 27 07:43:30 PDT 2017

Hahnfeld added a comment.

Two minor comments and `UNLIKELY` vs `__builtin_expect`

Comment at: runtime/src/kmp_tasking.cpp:894
                 gtid, loc_ref, KMP_TASK_TO_TASKDATA(task)));
   // this routine will provide task to resume
Hahnfeld wrote:
> omalyshe wrote:
> > to be removed
> Not done yet

Comment at: runtime/src/ompt-internal.h:34
+typedef struct kmp_taskdata kmp_taskdata_t;
protze.joachim wrote:
> Hahnfeld wrote:
> > Why is this here?
> Below in line 47, this is used to store the pointer for the scheduling task, which is needed to return the frame information.
Sure, shouldn't this live in `kmp.h` is it's not already there?


More information about the Openmp-commits mailing list