[Openmp-commits] [PATCH] D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

Two minor comments and `UNLIKELY` vs `__builtin_expect`



================
Comment at: runtime/src/kmp_tasking.cpp:894
                 gtid, loc_ref, KMP_TASK_TO_TASKDATA(task)));
+
   // this routine will provide task to resume
----------------
Hahnfeld wrote:
> omalyshe wrote:
> > to be removed
> Not done yet
Still


================
Comment at: runtime/src/ompt-internal.h:34
+
+typedef struct kmp_taskdata kmp_taskdata_t;
+
----------------
protze.joachim wrote:
> Hahnfeld wrote:
> > Why is this here?
> Below in line 47, this is used to store the pointer for the scheduling task, which is needed to return the frame information.
Sure, shouldn't this live in `kmp.h` is it's not already there?


https://reviews.llvm.org/D38185