[Openmp-commits] [PATCH] D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1

Joachim Protze via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Oct 27 07:37:43 PDT 2017

protze.joachim added inline comments.

Comment at: runtime/src/ompt-general.cpp:219
+  // Try tool-libraries-var ICV
+  const char *tool_libs = getenv("OMP_TOOL_LIBRARIES");
+  if (tool_libs) {
hbae wrote:
> Hahnfeld wrote:
> > Hasn't this been parsed to `__kmp_tool_libraries`?
> `__kmp_tool_libraries` is defined when the runtime reads environment variables, but `ompt_pre_init()` is called before that happens, so I think `__kmp_tool_libraries` is just used for printing the values of OMP_TOOL_LIBRARIES.
This function is reached before `__kmp_env_initialize`, so before `__kmp_tool_libraries`is set,

Comment at: runtime/src/ompt-internal.h:34
+typedef struct kmp_taskdata kmp_taskdata_t;
Hahnfeld wrote:
> Why is this here?
Below in line 47, this is used to store the pointer for the scheduling task, which is needed to return the frame information.


More information about the Openmp-commits mailing list