[Openmp-commits] [PATCH] D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added inline comments.


================
Comment at: runtime/test/ompt/loadtool/tool.c:1
+// RUN: true
+#include <stdio.h>
----------------
Hahnfeld wrote:
> protze.joachim wrote:
> > Hahnfeld wrote:
> > > That's not really a test...
> > We need the source for the library to be loaded by the other test in this directory (tool_available.c). What is your suggestion for having the code and library available?
> > 
> > We could merge the two files and separate the code by two ifdefs. The test would then compile the same file with two different defines.
> Ah, now I understand the intention. Right, that would be one solution and would keep the code together...
> Do we always need a `RUN` line? What happens if you just remove it?
Without a RUN line, lit complains about the missing RUN line. The lit summary lists the test as UNRESOLVED test.

So, probably merging the two files is the best approach.


https://reviews.llvm.org/D38185