[Openmp-commits] [PATCH] D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1

Olga Malysheva via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Oct 18 01:44:03 PDT 2017


omalyshe added inline comments.


================
Comment at: runtime/src/kmp_gsupport.cpp:940
 #endif
+      // TODO: Intel, why call kmpc and not kmp here?
       __kmpc_omp_task(&loc, gtid, task);
----------------
Hahnfeld wrote:
> Nothing to do with this patch but an interesting question...
It looks like this can be safely replaced with __kmp_omp_task. The eneral functionality is the same. The only loss would be some statistics (KMP_SET_THREAD_STATE_BLOCK(EXPLICIT_TASK)) that is not default anyway.


https://reviews.llvm.org/D38185





More information about the Openmp-commits mailing list