[Openmp-commits] [PATCH] D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1

[Jonathan Peyton via Phabricator via Openmp-commits]

jlpeyton added a comment.

A few more comments



================
Comment at: runtime/src/kmp_ftn_entry.h:347-349
+#if OMP_50_ENABLED
+int FTN_STDCALL xexpand(FTN_CONTROL_TOOL)(uint64_t command, uint64_t modifier,
+                                          void *arg) {
----------------
Remove the xexpand macro here since we aren't matching a version symbol with libgomp


================
Comment at: runtime/src/kmp_ftn_entry.h:1287
 // OMP_5.0 aliases
+xaliasify(FTN_CONTROL_TOOL, 50);
 #endif
----------------
Remove this as well for the same reason


================
Comment at: runtime/src/kmp_ftn_entry.h:1359
 // OMP_5.0 versioned symbols
+xversionify(FTN_CONTROL_TOOL, 50, "OMP_5.0");
 #endif
----------------
And remove this too.


https://reviews.llvm.org/D38185