[Openmp-commits] [PATCH] D38876: Restrict OMPT to OpenMP version 5.0 and remove old header files

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Oct 13 06:17:06 PDT 2017


Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.

LGTM with a comment about the error message



================
Comment at: runtime/CMakeLists.txt:334
+if(LIBOMP_OMPT_SUPPORT AND (${LIBOMP_OMP_VERSION} LESS 50))
+  message( FATAL_ERROR "OMPT is only available with OpenMP 5.0, LIBOMP_OMP_VERSION is ${LIBOMP_OMP_VERSION}" )
 endif()
----------------
Please use `libomp_error_say` as above and remove stray spaces. Should we say `OpenMP Tools Interface` here as well?


https://reviews.llvm.org/D38876





More information about the Openmp-commits mailing list