[Openmp-commits] [PATCH] D38837: Add explicit values to .clang-format

Joachim Protze via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Oct 12 09:51:26 PDT 2017

protze.joachim added inline comments.

Comment at: runtime/.clang-format:6
+AlignOperands: false
+DisableFormat:   true
+KeepEmptyLinesAtTheStartOfBlocks: false
jlpeyton wrote:
> This disables clang-format altogether when using -style=file?  Why would we want this and doesn't it make other changes to this file useless?  I believe we should just leave this file alone and clang-format the OMPT changes based on what the current configuration is.
I understand the comments below as the expected values for 
clang-format -dump-config -style=file
What we added is the diff of our output with the commented output. If the value is supposed to be false (as it is by default on my system/version) then this should also be changed below; and the value should still be explicitly listed as on some system the default seems to be true.


More information about the Openmp-commits mailing list