[Openmp-commits] [PATCH] D38292: KMP_HW_SUBSET vs KMP_PLACE_THREADS rival envirables fix

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov added inline comments.


================
Comment at: runtime/src/kmp_settings.cpp:4749
+
+      kmp_hw_subset->data = (void *)&rivals;
+      kmp_place_threads->data = (void *)&rivals;
----------------
This cast (void*) removes the volatile qualifier, that will make the compiler a bit unhappy.

I think we need const_cast here, e.g. CCAST(kmp_setting_t **, rivals), then it will be implicitly converted to (void*).


Repository:
  rL LLVM

https://reviews.llvm.org/D38292