[Openmp-commits] [PATCH] D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1

[Olga Malysheva via Phabricator via Openmp-commits]

omalyshe added inline comments.


================
Comment at: runtime/src/kmp_sched.cpp:142
 
-#if OMPT_SUPPORT && OMPT_TRACE
-    if (ompt_enabled && ompt_callbacks.ompt_callback(ompt_event_loop_begin)) {
-      ompt_callbacks.ompt_callback(ompt_event_loop_begin)(
-          team_info->parallel_id, task_info->task_id, team_info->microtask);
+// TODO for intel: need to be able to distinguish between sections and loops for
+// ompt callback
----------------
Remove the comment


================
Comment at: runtime/src/kmp_sched.cpp:198
 
-#if OMPT_SUPPORT && OMPT_TRACE
-    if (ompt_enabled && ompt_callbacks.ompt_callback(ompt_event_loop_begin)) {
-      ompt_callbacks.ompt_callback(ompt_event_loop_begin)(
-          team_info->parallel_id, task_info->task_id, team_info->microtask);
+// TODO for intel: (see first ompt callback in this function)
+#if OMPT_SUPPORT && OMPT_OPTIONAL
----------------
Remove the comment


================
Comment at: runtime/src/kmp_sched.cpp:231
 
-#if OMPT_SUPPORT && OMPT_TRACE
-    if (ompt_enabled && ompt_callbacks.ompt_callback(ompt_event_loop_begin)) {
-      ompt_callbacks.ompt_callback(ompt_event_loop_begin)(
-          team_info->parallel_id, task_info->task_id, team_info->microtask);
+// TODO for intel: (see first ompt callback in this function)
+#if OMPT_SUPPORT && OMPT_OPTIONAL
----------------
Remove the comment


================
Comment at: runtime/src/kmp_sched.cpp:392
 
-#if OMPT_SUPPORT && OMPT_TRACE
-  if (ompt_enabled && ompt_callbacks.ompt_callback(ompt_event_loop_begin)) {
-    ompt_callbacks.ompt_callback(ompt_event_loop_begin)(
-        team_info->parallel_id, task_info->task_id, team_info->microtask);
+// TODO for intel: (see first ompt callback in this function)
+#if OMPT_SUPPORT && OMPT_OPTIONAL
----------------
Remove the comment


================
Comment at: runtime/src/kmp_settings.cpp:4360
 
-// -----------------------------------------------------------------------------
+#if OMP_50_ENABLED && LIBOMP_OMPT_SUPPORT
+
----------------
LIBOMP_OMPT_SUPPORT -> OMPT_SUPPORT


================
Comment at: runtime/src/kmp_settings.cpp:4627
+
+#if OMP_50_ENABLED && LIBOMP_OMPT_SUPPORT
+    {"OMP_TOOL_LIBRARIES", __kmp_stg_parse_omp_tool_libraries,
----------------
LIBOMP_OMPT_SUPPORT -> OMPT_SUPPORT


================
Comment at: runtime/src/kmp_tasking.cpp:602
       1; // Execute this task immediately, not deferred.
+
   __kmp_task_start(gtid, task, current_task);
----------------
Remove extra empty line


================
Comment at: runtime/src/kmp_tasking.cpp:894
                 gtid, loc_ref, KMP_TASK_TO_TASKDATA(task)));
+
   // this routine will provide task to resume
----------------
to be removed


================
Comment at: runtime/src/kmp_tasking.cpp:900
                 gtid, loc_ref, KMP_TASK_TO_TASKDATA(task)));
+
   return;
----------------
to be removed


================
Comment at: runtime/src/kmp_tasking.cpp:1593
 
-// __kmpc_omp_taskwait: Wait until all tasks generated by the current task are
-// complete
-kmp_int32 __kmpc_omp_taskwait(ident_t *loc_ref, kmp_int32 gtid) {
+#if OMPT_SUPPORT
+OMPT_NOINLINE
----------------
Should it be under OMPT_OPTIONAL?


https://reviews.llvm.org/D38185