[Openmp-commits] [PATCH] D14254: [OpenMP] Initial implementation of OpenMP offloading library - libomptarget device RTLs.

[Arpith Jacob via Phabricator via Openmp-commits]

arpith-jacob added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:100
+};
+extern __device__ __shared__ DataSharingStateTy DataSharingState;
+
----------------
grokos wrote:
> Hahnfeld wrote:
> > This won't compile with current Clang 5.0.0:
> > ```
> > error: __shared__ variable 'DataSharingState' cannot be 'extern'
> > ```
> This looks like a clang problem. Shared variables can be extern. This code can be compiled with clang 4.0, maybe we should submit a bug report for clang 5.0?
Clang doesn't support this attribute and it requires additional investigation.  For now, I would disable building the bclib version of libomptarget-nvptx so that the runtime library is built using nvcc.


Repository:
  rL LLVM

https://reviews.llvm.org/D14254