[Openmp-commits] [PATCH] D40384: [OMPT] Add annotations to testcases that are expected to fail when using certain compilers

[Olga Malysheva via Phabricator via Openmp-commits]

omalyshe added a comment.

In https://reviews.llvm.org/D40384#939079, @sconvent wrote:

> In https://reviews.llvm.org/D40384#939025, @Hahnfeld wrote:
>
> > In https://reviews.llvm.org/D40384#938762, @omalyshe wrote:
> >
> > > In https://reviews.llvm.org/D40384#938757, @protze.joachim wrote:
> > >
> > > > @omalyshe Which version of icc introduced the ident information for workshare constructs?
> > >
> > >
> > > ICC with the ident information has not been released yet
> >
> >
> > In that case `cancel/cancel_worksharing.c` should fail for `icc-17, icc-18` too?
>
>
> No, the ident information was only missing for the worksharing constructs. For cancellation constructs, the compiler generates a call to '__kmpc_cancel(...)' with the correct kind parameter. icc-16 however did not generate the correct call.


Right, the ident information is needed only to distinguish worksharing constructs. ICC 17.0 will NOT have ident flags implemented; as for 18.0 - probably Update 2 will have it.


https://reviews.llvm.org/D40384