[Openmp-commits] [PATCH] D40595: [OMPT] Use frames at different level when using clang version 5 or higher with debug flag

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

(note: please post full context information as described in https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)



================
Comment at: runtime/test/ompt/callback.h:74
+  #endif
+  #if !defined(DEBUG) && defined(__clang__) && __clang_major__ >= 5
+    #warning "Clang 5.0 and later add an additional wrapper function for tasks when compiling with debug information."
----------------
I propose to always issue this warning: The test will also fail if the user specifies `-DDEBUG` without `-g`. In normal testing with lit, this won't do any harm because stderr is filtered away if the test is successful.


https://reviews.llvm.org/D40595