[Openmp-commits] [PATCH] D40081: [CMake] Refactor common settings and flags

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Nov 28 15:38:35 PST 2017


Hahnfeld added a comment.

Ok, I finally got your point. I especially agree on "The user may not know that something is only available on a certain platform until they request it" which kind of invalidates my previous arguments. I will update the patch tomorrow. I'm still tending towards putting this into the top-level `CMakeLists.txt`, right next to the definition of `OPENMP_ENABLE_LIBOMPTARGET` to have it in one place. What do you think?

Regarding `-std=c++11`: How does MSVC survive that LLVM check?


https://reviews.llvm.org/D40081





More information about the Openmp-commits mailing list