[Openmp-commits] [PATCH] D40080: [CMake] Disallow direct configuration

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: CMakeLists.txt:15-17
 
 add_subdirectory(runtime)
 
----------------
grokos wrote:
> jlpeyton wrote:
> > If it is possible, we should have an OPENMP_ENABLE_RUNTIME option so people can prevent building the runtime/ subdirectory and only build the libomptarget/ directory.  Does libomptarget rely on libomp?
> Yes, it does. It needs functions `omp_get_default_device()` and `__kmpc_omp_taskwait(void *loc_ref, int32_t gtid)`. More functions may be added to the list of dependencies in the future.
Yes, we could but my viewpoint was that there is no OpenMP with at least the host runtime.


================
Comment at: libomptarget/Build_With_CMake.txt:46-62
   inlude the -G <Generator name> option:
   $ cmake -G "Unix Makefiles" ...
   You can see a list of generators cmake supports by executing cmake with
   no arguments and a list will be printed.
 
 =====================
 Instructions to Build
----------------
jlpeyton wrote:
> I think libomptarget/Build_With_CMake.txt and runtime/Build_WIth_CMake.txt should be unified and moved into openmp/Build_With_CMake.txt.
Yes, it definitely should. I wanted to tackle this after the renaming of the test settings so that I can put together the file once with the final options.


https://reviews.llvm.org/D40080