[Openmp-commits] [PATCH] D40080: [CMake] Disallow direct configuration

[Pirama Arumuga Nainar via Phabricator via Openmp-commits]

pirama added inline comments.


================
Comment at: CMakeLists.txt:1
 cmake_minimum_required(VERSION 2.8 FATAL_ERROR)
 
----------------
Hahnfeld wrote:
> pirama wrote:
> > Hahnfeld wrote:
> > > pirama wrote:
> > > > Also, can we bump this up if there are no other issues?  The other LLVM projects are all currently using 3.4.3.
> > > Does that have any benefits? The LLVM requirement was bumped to use new features which I haven't come across yet in the openmp repository. So I'm somewhat reluctant as CMake 2.8 is still the default on CentOS, for example
> > CMake 3.4.3 defaults to the NEW behavior of `CMP0056`.  That's the only benefit for us, but it's easy enough to work around.   I don't know of any other major benefits there might be.
> IMO that's not enough to upgrade. If you need that policy, you should submit a patch to enable that one explicitly.
I agree.  I'll upload a patch once this current set of changes get submitted.


https://reviews.llvm.org/D40080