[Openmp-commits] [PATCH] D40080: [CMake] Disallow direct configuration

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: CMakeLists.txt:2
 cmake_minimum_required(VERSION 2.8 FATAL_ERROR)
 
+# llvm/runtimes/ will set OPENMP_STANDALONE_BUILD.
----------------
pirama wrote:
> There should be a `project()` declaration here.  If not, CMake adds an empty `project()` at the top of the file.  This breaks the Android build because the setting of the `CMP0056` policy via a CMake variable is not obeyed in this case.  `CMP0056` is needed to correctly configure cross-compile and linking for Android.
So you're currently configuring `runtime/` directly which has a `project()`?


https://reviews.llvm.org/D40080