[Openmp-commits] [PATCH] D39890: [OMPT] Fix assertion for OpenMP code generated with outdated compilers

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

To make the tests work with older compilers we need to reliably determine the compiler id and version. I'll be working on that.



================
Comment at: runtime/src/kmp_csupport.cpp:1777
+        if(!singleWarning){
+          __kmp_printf("OMPT Warning: The used compiler is outdated! The provided kind of worksharing event in OMPT is not reliable.\n");
+          singleWarning=1;
----------------
omalyshe wrote:
> I'd suggest using KMP_WARNING to emit standard RTL warning. 
> The message (in the message catalog) could be the following: "Cannot determine workshare type; using the default (loop) instead".
> 
> Also, it would be enough if only one thread emitted the warning. 
> 
In addition I think it would also be enough to diagnose in `__kmp_for_static_init`: The compiler will either generate the information for both calls or not at all.


https://reviews.llvm.org/D39890