[Openmp-commits] [PATCH] D39755: Remove const from variables with dynamic memory

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld marked an inline comment as done.
Hahnfeld added a comment.

In https://reviews.llvm.org/D39755#920386, @AndreyChurbanov wrote:

> Sorry, was too hasty.
>
> This patch gives me compile error:
>
> trunk/runtime/src/kmp_settings.cpp:1571:3: error: no matching function for call to
>
>       '__kmp_stg_parse_str'
>   __kmp_stg_parse_str(name, value, &__kmp_cpuinfo_file);
>   ^~~~~~~~~~~~~~~~~~~
>   
>
> So probably the __kmp_cpuinfo_file type should be changed to "char*", or const should be casted out.


Damn, this code was covered by `KMP_AFFINITY_SUPPORTED` which is set neither on my MacBook nor on Power. I "hacked" this by temporarily enabling it on Power. Would you be able to retest on x86 Linux?


https://reviews.llvm.org/D39755