[Openmp-commits] [PATCH] D39756: Add const to some variables to avoid const_casts

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld updated this revision to Diff 122242.
Hahnfeld added a comment.

Revert changes to `__kmp_parse_affinity_env` as they did not compile.


https://reviews.llvm.org/D39756

Files:
  runtime/src/kmp_settings.cpp
  runtime/src/kmp_utility.cpp


Index: runtime/src/kmp_utility.cpp
===================================================================
--- runtime/src/kmp_utility.cpp
+++ runtime/src/kmp_utility.cpp
@@ -96,14 +96,13 @@
     ) {
 
   double value = 0.0;
-  char const *unit = NULL;
+  char *unit = NULL;
   kmp_uint64 result = 0; /* Zero is a better unknown value than all ones. */
 
   if (frequency == NULL) {
     return result;
   }
-  value = strtod(frequency,
-                 CCAST(char **, &unit)); // strtod() does not like "const"
+  value = strtod(frequency, &unit);
   if (0 < value &&
       value <= DBL_MAX) { // Good value (not overflow, underflow, etc).
     if (strcmp(unit, "MHz") == 0) {
Index: runtime/src/kmp_settings.cpp
===================================================================
--- runtime/src/kmp_settings.cpp
+++ runtime/src/kmp_settings.cpp
@@ -3298,15 +3298,15 @@
     if (length > INT_MAX) {
       KMP_WARNING(LongValue, name);
     } else {
-      char *semicolon;
+      const char *semicolon;
       if (value[length - 1] == '"' || value[length - 1] == '\'')
         KMP_WARNING(UnbalancedQuotes, name);
       do {
         char sentinel;
 
-        semicolon = CCAST(char *, strchr(value, ';'));
+        semicolon = strchr(value, ';');
         if (*value && semicolon != value) {
-          char *comma = CCAST(char *, strchr(value, ','));
+          const char *comma = strchr(value, ',');
 
           if (comma) {
             ++comma;
@@ -3371,7 +3371,7 @@
   if (value) {
     length = KMP_STRLEN(value);
     if (length) {
-      char *comma = CCAST(char *, strchr(value, ','));
+      const char *comma = strchr(value, ',');
       if (value[length - 1] == '"' || value[length - 1] == '\'')
         KMP_WARNING(UnbalancedQuotes, name);
       /* get the specified scheduling style */


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39756.122242.patch
Type: text/x-patch
Size: 1808 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20171109/e595d2be/attachment.bin>