[Openmp-commits] [openmp] r304344 - Fix for KMP_AFFINITY=disabled and KMP_TOPOLOGY_METHOD=hwloc

[Jonathan Peyton via Openmp-commits]

Author: jlpeyton
Date: Wed May 31 15:35:22 2017
New Revision: 304344

URL: http://llvm.org/viewvc/llvm-project?rev=304344&view=rev
Log:
Fix for KMP_AFFINITY=disabled and KMP_TOPOLOGY_METHOD=hwloc

With these settings, the create_hwloc_map() method was being called causing an
assert(). After some consideration, it was determined that disabling affinity
explicitly should just disable hwloc as well. i.e., KMP_AFFINITY overrides
KMP_TOPOLOGY_METHOD. This lets the user know that the Hwloc mechanism is being
ignored when KMP_AFFINITY=disabled.

Differential Revision: https://reviews.llvm.org/D33208

Added:
    openmp/trunk/runtime/test/env/kmp_aff_disable_hwloc.c
Modified:
    openmp/trunk/runtime/src/kmp_affinity.cpp
    openmp/trunk/runtime/src/kmp_settings.cpp
    openmp/trunk/runtime/test/lit.cfg

Modified: openmp/trunk/runtime/src/kmp_affinity.cpp
URL: http://llvm.org/viewvc/llvm-project/openmp/trunk/runtime/src/kmp_affinity.cpp?rev=304344&r1=304343&r2=304344&view=diff
==============================================================================
--- openmp/trunk/runtime/src/kmp_affinity.cpp (original)
+++ openmp/trunk/runtime/src/kmp_affinity.cpp Wed May 31 15:35:22 2017
@@ -61,7 +61,10 @@ void KMPAffinity::pick_api() {
   if (picked_api)
     return;
 #if KMP_USE_HWLOC
-  if (__kmp_affinity_top_method == affinity_top_method_hwloc) {
+  // Only use Hwloc if affinity isn't explicitly disabled and
+  // user requests Hwloc topology method
+  if (__kmp_affinity_top_method == affinity_top_method_hwloc &&
+      __kmp_affinity_type != affinity_disabled) {
     affinity_dispatch = new KMPHwlocAffinity();
   } else
 #endif

Modified: openmp/trunk/runtime/src/kmp_settings.cpp
URL: http://llvm.org/viewvc/llvm-project/openmp/trunk/runtime/src/kmp_settings.cpp?rev=304344&r1=304343&r2=304344&view=diff
==============================================================================
--- openmp/trunk/runtime/src/kmp_settings.cpp (original)
+++ openmp/trunk/runtime/src/kmp_settings.cpp Wed May 31 15:35:22 2017
@@ -5033,6 +5033,16 @@ void __kmp_env_initialize(char const *st
     // affinity.
     const char *var = "KMP_AFFINITY";
     KMPAffinity::pick_api();
+#if KMP_USE_HWLOC
+    // If Hwloc topology discovery was requested but affinity was also disabled,
+    // then tell user that Hwloc request is being ignored and use default
+    // topology discovery method.
+    if (__kmp_affinity_top_method == affinity_top_method_hwloc &&
+        __kmp_affinity_dispatch->get_api_type() != KMPAffinity::HWLOC) {
+      KMP_WARNING(AffIgnoringHwloc, var);
+      __kmp_affinity_top_method = affinity_top_method_all;
+    }
+#endif
     if (__kmp_affinity_type == affinity_disabled) {
       KMP_AFFINITY_DISABLE();
     } else if (!KMP_AFFINITY_CAPABLE()) {

Added: openmp/trunk/runtime/test/env/kmp_aff_disable_hwloc.c
URL: http://llvm.org/viewvc/llvm-project/openmp/trunk/runtime/test/env/kmp_aff_disable_hwloc.c?rev=304344&view=auto
==============================================================================
--- openmp/trunk/runtime/test/env/kmp_aff_disable_hwloc.c (added)
+++ openmp/trunk/runtime/test/env/kmp_aff_disable_hwloc.c Wed May 31 15:35:22 2017
@@ -0,0 +1,21 @@
+// RUN: %libomp-compile && env KMP_AFFINITY=disabled KMP_TOPOLOGY_METHOD=hwloc %libomp-run
+// REQUIRES: hwloc
+#include <stdio.h>
+#include <stdlib.h>
+
+// Test will assert() without fix
+int test_affinity_disabled_plus_hwloc() {
+  #pragma omp parallel
+  {}
+  return 1;
+}
+
+int main(int argc, char **argv) {
+  int i, j;
+  int failed = 0;
+
+  if (!test_affinity_disabled_plus_hwloc()) {
+    failed = 1;
+  }
+  return failed;
+}

Modified: openmp/trunk/runtime/test/lit.cfg
URL: http://llvm.org/viewvc/llvm-project/openmp/trunk/runtime/test/lit.cfg?rev=304344&r1=304343&r2=304344&view=diff
==============================================================================
--- openmp/trunk/runtime/test/lit.cfg (original)
+++ openmp/trunk/runtime/test/lit.cfg Wed May 31 15:35:22 2017
@@ -64,6 +64,7 @@ if re.search('gcc', config.test_compiler
 append_dynamic_library_path(config.library_dir)
 if config.using_hwloc:
     append_dynamic_library_path(config.hwloc_library_dir)
+    config.available_features.add('hwloc')
 
 # Rpath modifications for Darwin
 if config.operating_system == 'Darwin':