[Openmp-commits] [openmp] r303086 - Remove some outdated comments
Jonathan Peyton via Openmp-commits
openmp-commits at lists.llvm.org
Mon May 15 10:39:16 PDT 2017
Author: jlpeyton
Date: Mon May 15 12:39:16 2017
New Revision: 303086
URL: http://llvm.org/viewvc/llvm-project?rev=303086&view=rev
Log:
Remove some outdated comments
Modified:
openmp/trunk/runtime/src/kmp_tasking.cpp
Modified: openmp/trunk/runtime/src/kmp_tasking.cpp
URL: http://llvm.org/viewvc/llvm-project/openmp/trunk/runtime/src/kmp_tasking.cpp?rev=303086&r1=303085&r2=303086&view=diff
==============================================================================
--- openmp/trunk/runtime/src/kmp_tasking.cpp (original)
+++ openmp/trunk/runtime/src/kmp_tasking.cpp Mon May 15 12:39:16 2017
@@ -1468,12 +1468,8 @@ kmp_int32 __kmpc_omp_taskwait(ident_t *l
KA_TRACE(10, ("__kmpc_omp_taskwait(enter): T#%d loc=%p\n", gtid, loc_ref));
if (__kmp_tasking_mode != tskm_immediate_exec) {
- // GEH TODO: shouldn't we have some sort of OMPRAP API calls here to mark
- // begin wait?
-
thread = __kmp_threads[gtid];
taskdata = thread->th.th_current_task;
-
#if OMPT_SUPPORT && OMPT_TRACE
ompt_task_id_t my_task_id;
ompt_parallel_id_t my_parallel_id;
@@ -1527,8 +1523,6 @@ kmp_int32 __kmpc_omp_taskwait(ident_t *l
__kmp_itt_taskwait_finished(gtid, itt_sync_obj);
#endif /* USE_ITT_BUILD */
- // GEH TODO: shouldn't we have some sort of OMPRAP API calls here to mark
- // end of wait?
// Debugger: The taskwait is completed. Location remains, but thread is
// negated.
taskdata->td_taskwait_thread = -taskdata->td_taskwait_thread;
@@ -1565,9 +1559,6 @@ kmp_int32 __kmpc_omp_taskyield(ident_t *
gtid, loc_ref, end_part));
if (__kmp_tasking_mode != tskm_immediate_exec && __kmp_init_parallel) {
- // GEH TODO: shouldn't we have some sort of OMPRAP API calls here to mark
- // begin wait?
-
thread = __kmp_threads[gtid];
taskdata = thread->th.th_current_task;
// Should we model this as a task wait or not?
@@ -1601,8 +1592,6 @@ kmp_int32 __kmpc_omp_taskyield(ident_t *
__kmp_itt_taskwait_finished(gtid, itt_sync_obj);
#endif /* USE_ITT_BUILD */
- // GEH TODO: shouldn't we have some sort of OMPRAP API calls here to mark
- // end of wait?
// Debugger: The taskwait is completed. Location remains, but thread is
// negated.
taskdata->td_taskwait_thread = -taskdata->td_taskwait_thread;
More information about the Openmp-commits
mailing list