[Openmp-commits] [PATCH] D31466: [OpenMP] Fix for http://bugs.llvm.org/show_bug.cgi?id=32456

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov added inline comments.


================
Comment at: runtime/CMakeLists.txt:311
+if(NOT LIBOMP_ENABLE_SHARED)
+  set(LIBOMP_USE_ITT_NOTIFY FALSE)
+endif()
----------------
jlpeyton wrote:
> Can you add a message like:
> libomp_say("ITT Notify not supported for static libraries - forcing ITT Notify off.")
Is it worth checking if the build is standalone, as we usually keep silence otherwise?
And if ITT notify was already turned off before this setting, we actually do not forcing it off, so no warning needed.

I'd make both checks, like
  if(LIBOMP_USE_ITT_NOTIFY AND NOT LIBOMP_ENABLE_SHARED)
    if(${LIBOMP_STANDALONE_BUILD})
      libomp_say("ITT Notify not supported for static libraries - forcing ITT Notify off")
    endif()
    set(LIBOMP_USE_ITT_NOTIFY FALSE)
  endif()

Is it better?


Repository:
  rL LLVM

https://reviews.llvm.org/D31466