[Openmp-commits] [PATCH] D31466: [OpenMP] Fix for http://bugs.llvm.org/show_bug.cgi?id=32456

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov created this revision.
Herald added subscribers: mgorny, rengolin.

The ittnotify API was mistakenly enabled for static runtime library initially. This fix disables the ittnotify for the static build.

Main problem with ittnotify in static library is impossibility to dynamically detect the presence of the tool at run time once the executable is linked statically, e.g. such interfaces as dlopen, dlsym etc. are inaccessible.


Repository:
  rL LLVM

https://reviews.llvm.org/D31466

Files:
  runtime/CMakeLists.txt


Index: runtime/CMakeLists.txt
===================================================================
--- runtime/CMakeLists.txt
+++ runtime/CMakeLists.txt
@@ -307,6 +307,10 @@
   libomp_error_say("Static libraries requested but not available on Windows")
 endif()
 
+if(NOT LIBOMP_ENABLE_SHARED)
+  set(LIBOMP_USE_ITT_NOTIFY FALSE)
+endif()
+
 # OMPT-support
 set(LIBOMP_OMPT_DEBUG FALSE CACHE BOOL
   "Trace OMPT initialization?")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31466.93378.patch
Type: text/x-patch
Size: 429 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20170329/5aa04520/attachment.bin>