[Openmp-commits] [PATCH] D30470: [cmake] Include openmp with add_llvm_external_project

[Chris Bieneman via Phabricator via Openmp-commits]

beanz accepted this revision.
beanz added a comment.

This patch is fine, just be warned that eventually I really want to kill the projects subdirectory entirely.

In general there are two types of "projects" that need to be added to the LLVM build tree: (1) projects that produce tools or libraries that depend on LLVM in some way, or (2) runtime libraries that are part of LLVM's compiler distribution.

The "projects" subdirectory has been used for things that fall into both of those categories, and it is confusing and complicated. In the future the plan is to make a clear distinction between the two types. Projects that depend on LLVM and should be integrated with LLVM's build system will be included under LLVM's "tools" directory which has an auto-discovery mechanism and does not require changes to the build system to do what this patch does. Additionally projects that produce runtime libraries will be included under LLVM's "runtimes" subdirectory, which supports configuring and building runtime library projects using just-built compiler toolchains.

There is no timeline for the removal of the projects directory, but please consider where openmp should fit in the future.


https://reviews.llvm.org/D30470