[Openmp-commits] [PATCH] D35719: [CMake] Allow to disable building libomptarget

[Hans Wennborg via Phabricator via Openmp-commits]

hans added inline comments.


================
Comment at: CMakeLists.txt:8
+
+set(ENABLE_LIBOMPTARGET ON)
 # Currently libomptarget cannot be compiled on Windows or MacOS X.
----------------
Hahnfeld wrote:
> hans wrote:
> > Since the tests fail by default, I think it should be disabled in the build by default.
> > 
> > trunk should always be in a working state.
> Well, it's broken since January so nobody cared enough. @gtbercea, what do you think?
Most people don't check out or build the openmp repo, and your buildbot doesn't run the tests -- which is another reason the code shouldn't be built by default.


https://reviews.llvm.org/D35719