[Openmp-commits] [PATCH] D30015: Add arch-specific directory to search path

Michał Górny via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Feb 17 14:39:59 PST 2017

mgorny accepted this revision.
mgorny added a comment.

LGTM modulo the test match split. But please wait for someone who has been longer here to confirm.

Comment at: test/Driver/arch-specific-libdir-rpath.c:18
+// CHECK-ARCHDIR: -L{{.*}}/Inputs/resource_dir_with_arch_subdir/lib/linux{{.*}} "-rpath" {{.*}}/Inputs/resource_dir_with_arch_subdir/lib/linux
+// CHECK-NO-ARCHDIR-NOT: -L{{.*}}Inputs/resource_dir
pirama wrote:
> Hahnfeld wrote:
> > Can you split that into two lines? Then it won't fail if there is some argument added in between
> Splitting into two lines makes FileCheck eagerly match the arch-subdir and -rpath into the {{.*}} next to the "-L".  This causes the check for -rpath to fail.
> The test accepts intermediate arguments because of the wildcard right after the -L...Inputs/...
Please do not rely on implicit assumptions like that. One day someone may decide to 'fix' the wildcard not to match whitespace, and make the wrong assumption about order. If for anything, splitting in two would make this more readable.


More information about the Openmp-commits mailing list