[Openmp-commits] [openmp] r293094 - [OpenMP] Initial implementation of OpenMP offloading library - libomptarget.

[Georgios Rokos via Openmp-commits]

Hans,

We have not tested libomptarget on Windows and indeed we don't have any
machine to test the library on.

Anyway, libomptarget in its current version comes with two plugins (elf64,
CUDA), both of which expect the user application fat binary to be in ELF
format, so by definition those plugins are not useful on Windows and
consequently the whole libomptarget library cannot be used right now.

George



From:	Hans Wennborg <hans at chromium.org>
To:	"Hahnfeld, Jonas" <Hahnfeld at itc.rwth-aachen.de>
Cc:	Georgios Rokos/Watson/IBM at IBMUS, "openmp-commits
            (openmp-commits at lists.llvm.org)"
            <openmp-commits at lists.llvm.org>
Date:	09/02/2017 17:21
Subject:	Re: [Openmp-commits] [openmp] r293094 - [OpenMP] Initial
            implementation of OpenMP offloading library - libomptarget.
Sent by:	hwennborg at google.com



It's difficult for me to try and debug this as the snapshots are built
by a lengthy batch process.

I've just removed the OpenMP runtime from the snapshots for now.

If you don't have a Windows machine setup for building, it sounds like
this isn't supported on Windows and should be disabled.

Thanks,
Hans

On Tue, Jan 31, 2017 at 12:02 AM, Hahnfeld, Jonas
<Hahnfeld at itc.rwth-aachen.de> wrote:
> Hi Hans,
>
>> -- LIBOMPTARGET: Building offloading runtime library libomptarget.
> should only be printed after -std=c++11 is checked, so libomptarget is
> probably built.
>
>> CMake Error at projects/openmp/libomptarget/CMakeLists.txt:101
(install):
>>   install Library TARGETS given no DESTINATION!
> is really weird because line 101 actually has a DESTINATION. However,
this is
> only applied for shared libraries if I understand the CMake documentation
for
> install() correctly.
> libomp specifies RUNTIME for WIN32 here... Would you mind testing with
RUNTIME
> instead of LIRBARY or without any keyword at all? I don't currently have
a
> Windows machine setup for building...
>
> Regards,
> Jonas
>
>> -----Original Message-----
>> From: hwennborg at google.com [mailto:hwennborg at google.com] On Behalf
>> Of Hans Wennborg
>> Sent: Monday, January 30, 2017 11:11 PM
>> To: George Rokos; Hahnfeld, Jonas
>> Cc: openmp-commits (openmp-commits at lists.llvm.org)
>> Subject: Re: [Openmp-commits] [openmp] r293094 - [OpenMP] Initial
>> implementation of OpenMP offloading library - libomptarget.
>>
>> Hi George,
>>
>> On Wed, Jan 25, 2017 at 1:27 PM, George Rokos via Openmp-commits
>> <openmp-commits at lists.llvm.org> wrote:
>> > Author: grokos
>> > Date: Wed Jan 25 15:27:24 2017
>> > New Revision: 293094
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=293094&view=rev
>> > Log:
>> > [OpenMP] Initial implementation of OpenMP offloading library -
>> libomptarget.
>> >
>> > This is the patch upstreaming the device-agnostic part of
libomptarget.
>> >
>> > Differential Revision: https://reviews.llvm.org/D14031
>>
>> I believe this broke self-hosting of clang+openmp on Windows.
>>
>> I get the following CMake error:
>>
>> -- LIBOMPTARGET: Building offloading runtime library libomptarget.
>> CMake Error at projects/openmp/libomptarget/CMakeLists.txt:101
(install):
>>   install Library TARGETS given no DESTINATION!
>>
>> I'm not sure that makes any sense.
>>
>> It seems the library does not get built with MSVC, probably because it
>> doesn't support the -std=c++11 option. But clang-cl does.
>>
>> Is this library expected to build on Windows? Otherwise, can we disable
it?
>>
>> For this week's Windows snapshot, I'll just exclude OpenMP.
>>
>> Thanks,
>> Hans



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20170209/ade41c30/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20170209/ade41c30/attachment.gif>