[Openmp-commits] [PATCH] D29638: Fix for bug https://llvm.org/bugs/show_bug.cgi?id=30889

[George Rokos via Phabricator via Openmp-commits]

grokos added a comment.

I am not an expert here and I'm not sure exactly how this works, but it seems to fix the problem.

One question though: The same assertion can be found throughout `kmp_runtime.cpp`, do other instances need this patching as well? E.g. line 2050, where there is a comment about a forthcoming patch that fixes the preconditions which spuriously make assertions to trigger.



================
Comment at: runtime/src/kmp_runtime.cpp:2050-2051
 #if 0
         // Patch out an assertion that trips while the runtime seems to operate correctly.
         // Avoiding the preconditions that cause the assertion to trip has been promised as a forthcoming patch.
         KMP_DEBUG_ASSERT(master_th->th.th_task_team == parent_team->t.t_task_team[master_th->th.th_task_state]);
----------------
What about here?


Repository:
  rL LLVM

https://reviews.llvm.org/D29638