[Openmp-commits] [PATCH] D40920: Unify build documentation and convert to reStructuredText

[Olga Malysheva via Phabricator via Openmp-commits]

omalyshe requested changes to this revision.
omalyshe added inline comments.
This revision now requires changes to proceed.


================
Comment at: README.rst:141
+**LIBOMP_MIC_ARCH** = ``knc|knf``
+  Intel(R) MIC architecture to build for.  This value is ignored if
+  **LIBOMP_ARCH** does not equal ``mic``.
----------------
The correct name is "Intel® Many Integrated Core Architecture (Intel® MIC Architecture)".


================
Comment at: README.rst:153
+  Use versioned symbols for building the library.  This option only makes sense
+  for ELF based libraries where version symbols are supported (Linux, some BSD*
+  variants).  It is ``OFF`` by default for Windows and Mac, but ``ON`` for other
----------------
Linux*****


================
Comment at: README.rst:154
+  for ELF based libraries where version symbols are supported (Linux, some BSD*
+  variants).  It is ``OFF`` by default for Windows and Mac, but ``ON`` for other
+  Unix based operating systems.
----------------
Windows*
macOS*


================
Comment at: README.rst:168
+
+Mac* Fat Libraries
+""""""""""""""""""
----------------
macOS* 
and the same in the next line OS X* ->macOS*


================
Comment at: README.rst:195
+**LIBOMP_OMPT_SUPPORT** = ``OFF|ON``
+  Include support for the OpenMP Tools Interface.
+
----------------
Probably it's worth to add "Include support for the OpenMP Tools Interface (OMPT)"


https://reviews.llvm.org/D40920