[Openmp-commits] [PATCH] D41182: [OMPT] Fix testcases for Intel Compiler

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

In https://reviews.llvm.org/D41182#955383, @omalyshe wrote:

> >   icc bug
>
> What bug it is and which version of ICC is affected?


Yes, this change also deserves a description of why this is needed. It also looks like the fuzzy address and noinline are two different problems that should be addressed separately.



================
Comment at: runtime/test/ompt/tasks/task_types.c:15
     char buffer[2048];
+    memset(buffer, 0, 2048);
     ompt_get_task_info(0, &task_type, NULL, NULL, NULL, NULL);
----------------
This should not be needed, `format_task_type` uses `sprintf` which automatically appends a null character.


================
Comment at: runtime/test/ompt/tasks/task_types_serialized.c:14
     char buffer[2048];
+    memset(buffer, 0, 2048);
     ompt_get_task_info(0, &task_type, NULL, NULL, NULL, NULL);
----------------
Same


https://reviews.llvm.org/D41182