[Openmp-commits] [PATCH] D41171: [OMPT] Handle null pointer correctly in set_callback

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Dec 20 01:00:31 PST 2017

Hahnfeld added a comment.

In https://reviews.llvm.org/D41171#953941, @protze.joachim wrote:

> This change is more a performace optimization. (reset the bit in the bitmap to 0)
>  The callback was set to NULL before and all callback invocation checks for the NULL-pointer.
> In some cases we do not enter a code path if a specific callback is not set. With this patch this code path is also not entered if the callback was set and reset to NULL.

Then title and summary should say that this is a for improving performace, that's impossible to guess from the changes.

Also, is this test case actually valid? I remember that some callbacks must always be set as pairs, not sure if that's true for parallel though.


More information about the Openmp-commits mailing list