[Openmp-commits] [PATCH] D14254: [OpenMP] Initial implementation of OpenMP offloading library - libomptarget device RTLs.

[George Rokos via Phabricator via Openmp-commits]

grokos added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.cu:20
+////////////////////////////////////////////////////////////////////////////////
+
+extern __device__
----------------
guansong wrote:
> if you move the include "state-queue.h" line in this cu and omp_data.cu into omptarget-nvptx.h, in my local build, right after conter_group.h
> 
> you will be able to common the global data tables in one location, in omptarget-nvptx.h, instead of having two copies.
Right, I moved it to `omptarget-nvptx.h` in the new diff. Thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D14254