[Openmp-commits] [PATCH] D41171: [OMPT] Handle null pointer correctly in set_callback

Joachim Protze via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Dec 13 07:54:34 PST 2017

protze.joachim added a comment.

This change is more a performace optimization. (reset the bit in the bitmap to 0)
The callback was set to NULL before and all callback invocation checks for the NULL-pointer.

In some cases we do not enter a code path if a specific callback is not set. With this patch this code path is also not entered if the callback was set and reset to NULL.

I agree that we might add a testcase, but the testcase will not show different behavior for this patch.


More information about the Openmp-commits mailing list