[Openmp-commits] [PATCH] D40384: [OMPT] Add annotations to testcases that are expected to fail when using certain compilers

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Dec 13 05:47:36 PST 2017

Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.

Two small things to considers, looks good otherwise.

Maybe we can commit all changes because of the GCC bug separately and add a meaningfull description? (no need to split this revision though)

Comment at: runtime/test/ompt/cancel/cancel_taskgroup.c:3
 // REQUIRES: ompt
-// Current GOMP interface implementation does not support cancellation
-// XFAIL: gcc
+// UNSUPPORTED: clang-3
+// Current GOMP interface implementation does not support cancellation; icc 16 has a bug
Please add `clang-4.0.0` if this test case triggers the hang on cancellation

Comment at: runtime/test/ompt/tasks/dependences.c:3
 // REQUIRES: ompt
+// XFAIL: gcc-4, gcc-5, gcc-6, gcc-7
Shouldn't this be `UNSUPPORTED` as well?


More information about the Openmp-commits mailing list