[Openmp-commits] [PATCH] D31923: Fix crash in invoking microtask on ios arm64

Andrey Churbanov via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Apr 12 09:21:36 PDT 2017

AndreyChurbanov requested changes to this revision.
AndreyChurbanov added a comment.
This revision now requires changes to proceed.

Couple notes.

1. Your patch breaks non-Linux ARM implementations I think, like FreeBSD ARM or NetBSD ARM.  It would be safer if you changed KMP_OS_LINUX to (KMP_OS_LINUX || KMP_OS_DARWIN) instead of removing KMP_OS_LINUX, so that other platforms were not affected.

2. Please upload the full diff as opposed to stripped, so that people could see more context around your changes.



More information about the Openmp-commits mailing list