[Openmp-commits] [PATCH] D26860: Fix for D25504 - segfault because of double free()-ing in task deps shutdown code.

Andrey Churbanov via Openmp-commits openmp-commits at lists.llvm.org
Mon Nov 21 08:22:18 PST 2016

AndreyChurbanov accepted this revision.
AndreyChurbanov added a comment.

> BTW, don't you think that the task->td_dephash pointer should be NULLified after calling __kmp_dephash_free() on it in kmp_taskdeps.cpp line 380?

I agree.  Keeping stale pointer is not good generally, regardless that it is not used.  So, writing NULL should be safer.  Of cause this cleanup can be done via a separate review.



More information about the Openmp-commits mailing list