[Openmp-commits] [PATCH] D25504: Fixes a memory leak related to task dependencies (patch from Alex Duran)

[Paul Osmialowski via Openmp-commits]

pawosm01 reopened this revision.
pawosm01 added a comment.
This revision is now accepted and ready to land.

Segfault at the fery first line of __kmp_dephash_free_entries() while trying to dereference a pointer passed as a parameter. The pointer to memory allocated by __kmp_fast_allocate() became invalid after __kmp_free_fast_memory() was called.



================
Comment at: runtime/src/kmp_runtime.c:5704
     #if USE_FAST_MEMORY
         __kmp_free_fast_memory( thread );
     #endif /* USE_FAST_MEMORY */
----------------
See comment below (line 5757)


================
Comment at: runtime/src/kmp_runtime.c:5757
 
+    __kmp_free_implicit_task(thread);
     __kmp_reap_team( thread->th.th_serial_team );
----------------
Calling this after __kmp_free_fast_memory( thread ); was called in line 5704 causes crash on sparselu_taskdep benchmark from kastors suite.


Repository:
  rL LLVM

https://reviews.llvm.org/D25504