[Openmp-commits] [PATCH] D26187: Change task stealing to always get task from head of victim's deque.

[Jonas Hahnfeld via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: runtime/src/kmp_tasking.c:1797
         if ( parent != current && (taskdata->td_flags.tiedness == TASK_TIED) ) { // untied is always allowed to be stolen
             // If the tail task is not a child, then no other childs can appear in the deque (?).
             __kmp_release_bootstrap_lock( & victim_td -> td.td_deque_lock );
----------------
Does this still hold then? I think currently a thread will add tasks to the tail so we have previously stolen the last generated task. However we are now going to take a task from the head.

If that is a problem, should we first try to steal from the head and afterwards check the tail if it's not a descendant task?


Repository:
  rL LLVM

https://reviews.llvm.org/D26187