[Openmp-commits] [PATCH] D19880: Fine tuning of TC* macros

[Paul Osmialowski via Openmp-commits]

pawosm01 added a comment.

As a side note, there is one more place that could be rearranged too: as I replaced no-op TCR_4 with actual code, compiler complained when building debug build. Following change was required:

diff --git a/runtime/src/kmp_tasking.c b/runtime/src/kmp_tasking.c
index 1d4ec35..e4d7bdc 100644

- a/runtime/src/kmp_tasking.c

+++ b/runtime/src/kmp_tasking.c
@@ -1832,7 +1832,7 @@ static inline int __kmp_execute_tasks_template(kmp_info_t *thread, kmp_int32 gti
 #else

  KMP_DEBUG_ASSERT( nthreads > 1 );

#endif

- KMP_DEBUG_ASSERT( TCR_4((int)*unfinished_threads) >= 0 );

+    KMP_DEBUG_ASSERT( (int)(TCR_4(*unfinished_threads)) >= 0 );
.

  // Choose tasks from our own work queue.
  start:

Please feel free to introduce this change during future refactors.


Repository:
  rL LLVM

http://reviews.llvm.org/D19880