[Openmp-commits] [PATCH] D19878: Use C++11 atomics for ticket locks implementation
Paul Osmialowski via Openmp-commits
openmp-commits at lists.llvm.org
Mon May 23 10:57:08 PDT 2016
pawosm01 added a comment.
Although most of Johns suggestions are good subject of bigger refactor (e.g. GTID_TO_LOCK_OWNER affects other lock mechanisms too), I think his remark regarding lack of atomic store in __kmp_release_ticket_lock_with_checks() is relevant here. And also seems like I didn't update my patch with 'self' field removal. Now we got two options 1) land it as it is and prepare the next patch which should address 'self' field issue and John's issues number 1, 2, 3 and 6 (while 4, 5 and 7 are outside of the scope of this change) or 2) wait 2-3 days until I finish checking updated patch where 'self' is removed and missing atomic store is added.
More information about the Openmp-commits