[Openmp-commits] [openmp] r273438 - Apply the KMP_USE_FUTEX feature macro everywhere

Peyton, Jonathan L via Openmp-commits openmp-commits at lists.llvm.org
Thu Jun 23 09:19:57 PDT 2016


http://llvm.org/docs/TestingGuide.html#writing-new-regression-tests
suggests that the lines form a "script" for lit.  The example they give requires that they run in order as well.

I'm going to remove the "%libomp-compile &&" from the second run line.

-- Johnny

-----Original Message-----
From: Hahnfeld, Jonas [mailto:Hahnfeld at itc.rwth-aachen.de] 
Sent: Thursday, June 23, 2016 9:40 AM
To: Peyton, Jonathan L <jonathan.l.peyton at intel.com>
Cc: openmp-commits at lists.llvm.org
Subject: RE: [Openmp-commits] [openmp] r273438 - Apply the KMP_USE_FUTEX feature macro everywhere

Hi Jonathan,

> -----Original Message-----
> From: Openmp-commits [mailto:openmp-commits-bounces at lists.llvm.org]
> On Behalf Of Jonathan Peyton via Openmp-commits
> Sent: Wednesday, June 22, 2016 6:35 PM
> To: openmp-commits at lists.llvm.org
> Subject: [Openmp-commits] [openmp] r273438 - Apply the KMP_USE_FUTEX
> feature macro everywhere
>
> Author: jlpeyton
> Date: Wed Jun 22 11:35:12 2016
> New Revision: 273438
>
> URL: http://llvm.org/viewvc/llvm-project?rev=273438&view=rev
> Log:
> Apply the KMP_USE_FUTEX feature macro everywhere
>
> Modified:
>     openmp/trunk/runtime/src/kmp_csupport.c
>     openmp/trunk/runtime/src/kmp_lock.h
>     openmp/trunk/runtime/src/z_Linux_util.c
>     openmp/trunk/runtime/test/lock/omp_lock.c
>
> [...]
>
> Modified: openmp/trunk/runtime/test/lock/omp_lock.c
> URL: http://llvm.org/viewvc/llvm-
> project/openmp/trunk/runtime/test/lock/omp_lock.c?rev=273438&r1=2734
> 37&r2=273438&view=diff
> ==========================================================
> ====================
> --- openmp/trunk/runtime/test/lock/omp_lock.c (original)
> +++ openmp/trunk/runtime/test/lock/omp_lock.c Wed Jun 22 11:35:12 2016
> @@ -1,5 +1,6 @@
>  // RUN: %libomp-compile-and-run
>  // RUN: %libomp-compile && env KMP_LOCK_KIND=tas
> KMP_SPIN_BACKOFF_PARAMS=2048,200 %libomp-run
> +// RUN: env KMP_LOCK_KIND=futex %libomp-run
>  #include <stdio.h>
>  #include "omp_testsuite.h"

I think we should either always compile or only once in the beginning. Is 
there a guarantee that the lines are executed in order?

Greetings,
Jonas


More information about the Openmp-commits mailing list