[Openmp-commits] [PATCH] D20879: Refactor __kmp_execute_tasks_template function

Terry Wilmarth via Openmp-commits openmp-commits at lists.llvm.org
Wed Jun 1 14:31:55 PDT 2016


tlwilmar created this revision.
tlwilmar added reviewers: AndreyChurbanov, jlpeyton.
tlwilmar added a subscriber: openmp-commits.
tlwilmar set the repository for this revision to rL LLVM.

Refactored __kmp_execute_tasks_template to shorten and remove code redundancy.

The original code for __kmp_execute_tasks_template was very redundant with large sections of repeated code that needed to be kept consistent, and goto statements that made the control flow difficult to discern.  This refactoring removes all gotos and redundancy.

The diff is pretty much non-sensical because the structure has changed so much and LOC reduced a lot.  Best to just read and understand the new code.

Repository:
  rL LLVM

http://reviews.llvm.org/D20879

Files:
  runtime/src/kmp_tasking.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20879.59278.patch
Type: text/x-patch
Size: 22191 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20160601/41456dae/attachment-0001.bin>


More information about the Openmp-commits mailing list