[Openmp-commits] [PATCH] D14746: Add support for ompt_event_task_dependences and ompt_event_task_dependence_pair

[Harald Servat via Openmp-commits]

harald.servat added a comment.

In http://reviews.llvm.org/D14746#338164, @Hahnfeld wrote:

> LGTM. Shall I commit for you?




  Yes, please. Thank you very much!

> In http://reviews.llvm.org/D14746#338148, @harald.servat wrote:

> 

> > I have addressed Jonas Hahnfeld by guarding the code with OMP_40_ENABLED.

> >

> > My only concern is regarding runtime/src/ompt-event-specific.h. In that file, I have added the guard but I also provided the #else condition to mark that these events cannot be provided if OMP40 is not enabled.

> 

> 

> Good idea, this makes it explicitely clear that this is not implemented for versions prior to 4.0 (although the defines will probably never be used in this case...)





http://reviews.llvm.org/D14746