[Openmp-commits] [openmp] r258985 - Fixing comments.
Jonathan Peyton via Openmp-commits
openmp-commits at lists.llvm.org
Wed Jan 27 12:57:32 PST 2016
Author: jlpeyton
Date: Wed Jan 27 14:57:32 2016
New Revision: 258985
URL: http://llvm.org/viewvc/llvm-project?rev=258985&view=rev
Log:
Fixing comments.
Removing references to non-existent functions, fixing typos.
Modified:
openmp/trunk/runtime/src/kmp_barrier.cpp
openmp/trunk/runtime/src/kmp_runtime.c
openmp/trunk/runtime/src/z_Windows_NT_util.c
Modified: openmp/trunk/runtime/src/kmp_barrier.cpp
URL: http://llvm.org/viewvc/llvm-project/openmp/trunk/runtime/src/kmp_barrier.cpp?rev=258985&r1=258984&r2=258985&view=diff
==============================================================================
--- openmp/trunk/runtime/src/kmp_barrier.cpp (original)
+++ openmp/trunk/runtime/src/kmp_barrier.cpp Wed Jan 27 14:57:32 2016
@@ -1457,8 +1457,6 @@ __kmp_join_barrier(int gtid)
the kmp_task_team_t structs. */
if (KMP_MASTER_TID(tid)) {
if (__kmp_tasking_mode != tskm_immediate_exec) {
- // Master shouldn't call decrease_load(). // TODO: enable master threads.
- // Master should have th_may_decrease_load == 0. // TODO: enable master threads.
__kmp_task_team_wait(this_thr, team
USE_ITT_BUILD_ARG(itt_sync_obj) );
}
Modified: openmp/trunk/runtime/src/kmp_runtime.c
URL: http://llvm.org/viewvc/llvm-project/openmp/trunk/runtime/src/kmp_runtime.c?rev=258985&r1=258984&r2=258985&view=diff
==============================================================================
--- openmp/trunk/runtime/src/kmp_runtime.c (original)
+++ openmp/trunk/runtime/src/kmp_runtime.c Wed Jan 27 14:57:32 2016
@@ -637,8 +637,7 @@ DllMain( HINSTANCE hInstDLL, DWORD fdwRe
// When the process terminates, worker threads disappear triggering
// the problem of unreleased forkjoin lock as described below.
- // A worker thread can take the forkjoin lock
- // in __kmp_suspend_template()->__kmp_rml_decrease_load_before_sleep().
+ // A worker thread can take the forkjoin lock.
// The problem comes up if that worker thread becomes dead
// before it releases the forkjoin lock.
// The forkjoin lock remains taken, while the thread
@@ -5699,7 +5698,7 @@ __kmp_reap_thread(
//
// The thread was killed asynchronously. If it was actively
- // spinning in the in the thread pool, decrement the global count.
+ // spinning in the thread pool, decrement the global count.
//
// There is a small timing hole here - if the worker thread was
// just waking up after sleeping in the pool, had reset it's
Modified: openmp/trunk/runtime/src/z_Windows_NT_util.c
URL: http://llvm.org/viewvc/llvm-project/openmp/trunk/runtime/src/z_Windows_NT_util.c?rev=258985&r1=258984&r2=258985&view=diff
==============================================================================
--- openmp/trunk/runtime/src/z_Windows_NT_util.c (original)
+++ openmp/trunk/runtime/src/z_Windows_NT_util.c Wed Jan 27 14:57:32 2016
@@ -19,11 +19,6 @@
#include "kmp_io.h"
#include "kmp_wait_release.h"
-
-
-/* ----------------------------------------------------------------------------------- */
-/* ----------------------------------------------------------------------------------- */
-
/* This code is related to NtQuerySystemInformation() function. This function
is used in the Load balance algorithm for OMP_DYNAMIC=true to find the
number of running threads in the system. */
More information about the Openmp-commits
mailing list