[Openmp-commits] [PATCH] D16921: [GCC] GOMP_task: Change argument type of if_cond from int to bool

Jonas Hahnfeld via Openmp-commits openmp-commits at lists.llvm.org
Fri Feb 5 04:55:43 PST 2016


Hahnfeld created this revision.
Hahnfeld added reviewers: jlpeyton, AndreyChurbanov.
Hahnfeld added a subscriber: openmp-commits.

(libgomp has `bool` as well)

This was causing a test failure in `omp_test_if.c` when building with GCC in Debug mode. I have verified that GCC versions 4.9.2 and 5.3.0 now work and compile-tested this change with clang 3.7.1 and Intel Compiler 16.0.

http://reviews.llvm.org/D16921

Files:
  runtime/src/kmp_gsupport.c

Index: runtime/src/kmp_gsupport.c
===================================================================
--- runtime/src/kmp_gsupport.c
+++ runtime/src/kmp_gsupport.c
@@ -924,7 +924,7 @@
 
 void
 xexpand(KMP_API_NAME_GOMP_TASK)(void (*func)(void *), void *data, void (*copy_func)(void *, void *),
-  long arg_size, long arg_align, int if_cond, unsigned gomp_flags)
+  long arg_size, long arg_align, bool if_cond, unsigned gomp_flags)
 {
     MKLOC(loc, "GOMP_task");
     int gtid = __kmp_entry_gtid();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D16921.47010.patch
Type: text/x-patch
Size: 500 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20160205/bd4f40b2/attachment.bin>


More information about the Openmp-commits mailing list