[Openmp-commits] [PATCH] D16714: [OMPT] Fix wrong parent_task_id in serialized parallel_begin with GCC

Jonas Hahnfeld via Openmp-commits openmp-commits at lists.llvm.org
Fri Feb 5 00:41:33 PST 2016

Hahnfeld added a comment.

In http://reviews.llvm.org/D16714#344529, @jmellorcrummey wrote:

> I haven't had the time to analyze this patch in detail. To me, it looks like it fixes a symptom (an incorrect argument passed to a callback) rather than an underlying cause (information about the top task frame may be improperly updated).
> If the information for the task at depth 0 before the serialized parallel is what should be presented to the parallel begin callback, then is the information at depth 0 wrong? Remember, a tool using asynchronous sampling could observe this task at any time - either before or after the serialized parallel.

Not sure if I completely get your point...
What I have just tested is that the ids reported by `ompt_get_{parallel,task}_id` are correct when sampling user code. I think this is because there is a lightweight taskteam constructed on line `417` (with the patch applied)


More information about the Openmp-commits mailing list