[Openmp-commits] [PATCH] D27647: Fix arguments of trace output in __kmp_push_stack

Andrey Churbanov via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Dec 12 04:20:31 PST 2016


AndreyChurbanov added a comment.

Good catch!

Could you also move the KA_TRACE statement above the __kmp_release_bootstrap_lock().  Because currently the printed data may not be related to the pushed task if some other task is pushed between lock releasing and the print itself. Having the print inside critical section would guarantee the relevant data printed.

Thanks, Andrey


https://reviews.llvm.org/D27647





More information about the Openmp-commits mailing list