[Openmp-commits] [PATCH] D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs
firstname.lastname@example.org via Openmp-commits
openmp-commits at lists.llvm.org
Wed Sep 23 14:36:07 PDT 2015
hfinkel added a comment.
In http://reviews.llvm.org/D13072#252176, @simoatze wrote:
> In http://reviews.llvm.org/D13072#252137, @hfinkel wrote:
> > Thanks for working on this; I'm very excited to see this functionality!
> > As a general comment, can you always define ANNOTATE_* macros, and just make them empty if TSAN_SUPPORT is not true. What would make things less verbose.
> Oh I guess you mean to remove all the TSAN_SUPPORT and just leave the ANNOTATIONS, if TSAN support is not defined it will make them empty, right?
Yes, exactly. That way each annotation is one line instead of three ;)
More information about the Openmp-commits