[Openmp-commits] [PATCH] D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs

[Jonas Hahnfeld via Openmp-commits]

Hahnfeld added a subscriber: Hahnfeld.
Hahnfeld added a comment.

I have only marked one of the whitespace issues...


================
Comment at: runtime/CMakeLists.txt:293
@@ +292,3 @@
+if(${LIBOMP_TSAN_SUPPORT})
+  add_definitions(-D TSAN_SUPPORT=1 -D DYNAMIC_ANNOTATIONS_ENABLED=1)
+  set(LIBOMP_TSAN_NAME _tsan)
----------------
Could this be moved to `kmp_config.h.cmake`?

================
Comment at: runtime/src/kmp_barrier.cpp:78
@@ +77,3 @@
+#if TSAN_SUPPORT
+	ANNOTATE_HAPPENS_BEFORE(this_thr);
+#endif
----------------
tab instead of 4 spaces


http://reviews.llvm.org/D13072