[Openmp-commits] [PATCH] D12331: Removing the Makefile+Perl build system

[Jonas Hahnfeld via Openmp-commits]

Hahnfeld added a subscriber: Hahnfeld.
Hahnfeld requested changes to this revision.
Hahnfeld added a reviewer: Hahnfeld.
Hahnfeld added a comment.
This revision now requires changes to proceed.

Please see inline comments


================
Comment at: runtime/README.txt:41
@@ +40,3 @@
+$ mkdir build && cd build
+$ cmake -DCMAKE_C_COMPILER=<C compiler> -DCMAKE_CXX_COMPILER=<C++ compiler> ..
+$ make
----------------
the build dir may not necessarily be inside the src dir. libc++ uses `path/to/libcxx`...

================
Comment at: www/index.html:158
@@ -157,3 +157,3 @@
   <ul>
-  <li><code>svn co http://llvm.org/svn/llvm-project/openmp/trunk openmp</code></li>
+  <li><code>svn co http://llvm.org/svn/llvm-project/openmp/trunk libomp</code></li>
   </ul>
----------------
Do we really want to call it `libomp`?

I remember D9534 where it was expected to be called `openmp`. And there may be other components than just libomp in this repository at some point of time...

(Please also fix the other locations where it says `libomp`)


Repository:
  rL LLVM

http://reviews.llvm.org/D12331